Skip to content

Refactor ydb cli options#15800

Merged
UgnineSirdis merged 6 commits into
ydb-platform:mainfrom
UgnineSirdis:refactor-ydb-cli-options
Mar 26, 2025
Merged

Refactor ydb cli options#15800
UgnineSirdis merged 6 commits into
ydb-platform:mainfrom
UgnineSirdis:refactor-ydb-cli-options

Conversation

@UgnineSirdis

@UgnineSirdis UgnineSirdis commented Mar 17, 2025

Copy link
Copy Markdown
Collaborator

Changelog entry

YDB CLI help message improvements. Different display for detailed help and brief help.

Changelog category

  • Improvement

Description for reviewers

Removed copy-paste style code for options handling. Instead wrote classes that are similar to command line options classes, but additionally can work with YDB CLI specific things like parsing from env variable, from explicitly specified and current active profile, doc link, prioritize auth method parsing from env etc.

Also there are improvements in help message display. Parsing sources and additional information are displayed automatically with one unified code that generates full help string.

@UgnineSirdis UgnineSirdis requested review from a team as code owners March 17, 2025 08:35
@github-actions

github-actions Bot commented Mar 17, 2025

Copy link
Copy Markdown
Contributor

🟢 2025-03-17 08:36:16 UTC The validation of the Pull Request description is successful.

@github-actions

github-actions Bot commented Mar 17, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

⚪ 2025-03-17 08:36:25 UTC Pre-commit check linux-x86_64-release-asan for 72193f8 has started.
⚪ 2025-03-17 08:36:40 UTC Artifacts will be uploaded here
⚪ 2025-03-17 08:39:32 UTC ya make is running...
🔴 2025-03-17 08:42:49 UTC Build failed, see the logs. Also see fail summary

@github-actions

github-actions Bot commented Mar 17, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

⚪ 2025-03-17 08:36:28 UTC Pre-commit check linux-x86_64-relwithdebinfo for 72193f8 has started.
⚪ 2025-03-17 08:36:43 UTC Artifacts will be uploaded here
⚪ 2025-03-17 08:39:48 UTC ya make is running...
🔴 2025-03-17 08:42:59 UTC Build failed, see the logs. Also see fail summary

@UgnineSirdis UgnineSirdis force-pushed the refactor-ydb-cli-options branch from 14b6b4f to cf80ca4 Compare March 17, 2025 09:44
@github-actions

github-actions Bot commented Mar 17, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

⚪ 2025-03-17 09:48:20 UTC Pre-commit check linux-x86_64-relwithdebinfo for dfaa80d has started.
⚪ 2025-03-17 09:48:35 UTC Artifacts will be uploaded here
⚪ 2025-03-17 09:51:23 UTC ya make is running...
⚫ 2025-03-17 09:51:54 UTC Check cancelled

@github-actions

github-actions Bot commented Mar 17, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

⚪ 2025-03-17 09:48:41 UTC Pre-commit check linux-x86_64-release-asan for dfaa80d has started.
⚪ 2025-03-17 09:48:55 UTC Artifacts will be uploaded here
⚫ 2025-03-17 09:51:51 UTC Check cancelled

@UgnineSirdis UgnineSirdis force-pushed the refactor-ydb-cli-options branch from cf80ca4 to a659db8 Compare March 17, 2025 09:51
@github-actions

github-actions Bot commented Mar 17, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

⚪ 2025-03-17 09:54:11 UTC Pre-commit check linux-x86_64-release-asan for e4a7423 has started.
⚪ 2025-03-17 09:54:25 UTC Artifacts will be uploaded here
⚪ 2025-03-17 09:57:09 UTC ya make is running...
🟡 2025-03-17 11:04:25 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12260 12161 0 42 18 39

⚪ 2025-03-17 11:05:50 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-17 11:27:07 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
134 (only retried tests) 90 0 2 6 36

⚪ 2025-03-17 11:27:17 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-03-17 11:45:45 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
75 (only retried tests) 35 0 0 6 34

🟢 2025-03-17 11:45:51 UTC Build successful.
🟡 2025-03-17 11:46:20 UTC ydbd size 3.8 GiB changed* by +106.8 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: b1bf2aa merge: e4a7423 diff diff %
ydbd size 4 046 862 040 Bytes 4 046 971 376 Bytes +106.8 KiB +0.003%
ydbd stripped size 1 400 135 816 Bytes 1 400 287 496 Bytes +148.1 KiB +0.011%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions

github-actions Bot commented Mar 17, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

⚪ 2025-03-17 09:54:11 UTC Pre-commit check linux-x86_64-relwithdebinfo for e4a7423 has started.
⚪ 2025-03-17 09:54:26 UTC Artifacts will be uploaded here
⚪ 2025-03-17 09:57:13 UTC ya make is running...
🟡 2025-03-17 10:56:30 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
26669 23954 0 115 2484 116

⚪ 2025-03-17 10:58:54 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-17 11:28:35 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
288 (only retried tests) 68 0 109 4 107

⚪ 2025-03-17 11:28:46 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-03-17 11:55:58 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
262 (only retried tests) 46 0 108 0 108

🟢 2025-03-17 11:56:10 UTC Build successful.
🟢 2025-03-17 11:56:34 UTC ydbd size 2.1 GiB changed* by +36.8 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: b1bf2aa merge: e4a7423 diff diff %
ydbd size 2 298 321 792 Bytes 2 298 359 456 Bytes +36.8 KiB +0.002%
ydbd stripped size 481 108 704 Bytes 481 142 176 Bytes +32.7 KiB +0.007%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@UgnineSirdis UgnineSirdis force-pushed the refactor-ydb-cli-options branch from a659db8 to 29bb484 Compare March 17, 2025 18:35
@github-actions

github-actions Bot commented Mar 17, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

⚪ 2025-03-17 18:39:21 UTC Pre-commit check linux-x86_64-relwithdebinfo for ff4fef4 has started.
⚪ 2025-03-17 18:39:37 UTC Artifacts will be uploaded here
⚪ 2025-03-17 18:42:30 UTC ya make is running...
🟡 2025-03-17 19:47:36 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
26676 24068 0 6 2486 116

⚪ 2025-03-17 19:49:47 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-03-17 20:02:24 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
177 (only retried tests) 66 0 0 1 110

🟢 2025-03-17 20:02:31 UTC Build successful.
🟢 2025-03-17 20:02:50 UTC ydbd size 2.1 GiB changed* by +32.8 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: a0ceb34 merge: ff4fef4 diff diff %
ydbd size 2 298 537 488 Bytes 2 298 571 096 Bytes +32.8 KiB +0.001%
ydbd stripped size 481 147 840 Bytes 481 177 344 Bytes +28.8 KiB +0.006%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions

github-actions Bot commented Mar 17, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

⚪ 2025-03-17 18:39:25 UTC Pre-commit check linux-x86_64-release-asan for ff4fef4 has started.
⚪ 2025-03-17 18:39:41 UTC Artifacts will be uploaded here
⚪ 2025-03-17 18:42:34 UTC ya make is running...
🟡 2025-03-17 19:48:51 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12265 12168 0 36 22 39

⚪ 2025-03-17 19:49:57 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-17 20:02:34 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
146 (only retried tests) 101 0 1 8 36

⚪ 2025-03-17 20:02:42 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-03-17 20:20:46 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
75 (only retried tests) 33 0 0 5 37

🟢 2025-03-17 20:20:53 UTC Build successful.
🟡 2025-03-17 20:21:23 UTC ydbd size 3.8 GiB changed* by +107.0 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: a0ceb34 merge: ff4fef4 diff diff %
ydbd size 4 047 169 640 Bytes 4 047 279 232 Bytes +107.0 KiB +0.003%
ydbd stripped size 1 400 234 440 Bytes 1 400 386 280 Bytes +148.3 KiB +0.011%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@UgnineSirdis UgnineSirdis force-pushed the refactor-ydb-cli-options branch from 29bb484 to 602a9e1 Compare March 23, 2025 07:18
@github-actions

github-actions Bot commented Mar 23, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

⚪ 2025-03-23 07:22:32 UTC Pre-commit check linux-x86_64-relwithdebinfo for 71b437f has started.
⚪ 2025-03-23 07:22:46 UTC Artifacts will be uploaded here
⚪ 2025-03-23 07:25:30 UTC ya make is running...
🟡 2025-03-23 08:27:28 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
26815 24201 0 3 2492 119

⚪ 2025-03-23 08:29:39 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-23 08:40:28 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
163 (only retried tests) 55 0 2 0 106

⚪ 2025-03-23 08:40:36 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-03-23 08:50:45 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
152 (only retried tests) 45 0 2 0 105

🟢 2025-03-23 08:50:52 UTC Build successful.
🟢 2025-03-23 08:51:12 UTC ydbd size 2.2 GiB changed* by +33.2 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 58fbe04 merge: 71b437f diff diff %
ydbd size 2 319 772 768 Bytes 2 319 806 816 Bytes +33.2 KiB +0.001%
ydbd stripped size 484 954 016 Bytes 484 983 648 Bytes +28.9 KiB +0.006%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions

github-actions Bot commented Mar 23, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

⚪ 2025-03-23 07:22:35 UTC Pre-commit check linux-x86_64-release-asan for 71b437f has started.
⚪ 2025-03-23 07:22:50 UTC Artifacts will be uploaded here
⚪ 2025-03-23 07:25:33 UTC ya make is running...
🟡 2025-03-23 08:39:11 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12372 12243 0 73 17 39

⚪ 2025-03-23 08:40:14 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-23 08:52:30 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
172 (only retried tests) 130 0 3 6 33

⚪ 2025-03-23 08:52:38 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-03-23 09:04:30 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
68 (only retried tests) 30 0 4 1 33

🟢 2025-03-23 09:04:37 UTC Build successful.
🟡 2025-03-23 09:05:06 UTC ydbd size 3.8 GiB changed* by +107.6 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 58fbe04 merge: 71b437f diff diff %
ydbd size 4 081 211 408 Bytes 4 081 321 632 Bytes +107.6 KiB +0.003%
ydbd stripped size 1 410 078 216 Bytes 1 410 230 344 Bytes +148.6 KiB +0.011%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@UgnineSirdis UgnineSirdis force-pushed the refactor-ydb-cli-options branch from 602a9e1 to 3b3a410 Compare March 25, 2025 14:18
@github-actions

github-actions Bot commented Mar 25, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

⚪ 2025-03-25 14:21:54 UTC Pre-commit check linux-x86_64-relwithdebinfo for 9bdddb1 has started.
⚪ 2025-03-25 14:22:09 UTC Artifacts will be uploaded here
⚪ 2025-03-25 14:25:02 UTC ya make is running...
🟡 2025-03-25 15:37:18 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
26887 24225 0 5 2546 111

⚪ 2025-03-25 15:39:37 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-03-25 15:49:48 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
164 (only retried tests) 63 0 0 0 101

🟢 2025-03-25 15:49:58 UTC Build successful.
🟢 2025-03-25 15:50:17 UTC ydbd size 2.2 GiB changed* by +32.8 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 9808a23 merge: 9bdddb1 diff diff %
ydbd size 2 321 300 104 Bytes 2 321 333 672 Bytes +32.8 KiB +0.001%
ydbd stripped size 485 307 456 Bytes 485 336 928 Bytes +28.8 KiB +0.006%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions

github-actions Bot commented Mar 25, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

⚪ 2025-03-25 14:21:59 UTC Pre-commit check linux-x86_64-release-asan for 9bdddb1 has started.
⚪ 2025-03-25 14:22:15 UTC Artifacts will be uploaded here
⚪ 2025-03-25 14:25:09 UTC ya make is running...
🟡 2025-03-25 15:42:40 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12386 12236 0 93 20 37

⚪ 2025-03-25 15:43:46 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-25 16:04:36 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
208 (only retried tests) 170 0 3 4 31

⚪ 2025-03-25 16:04:50 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-03-25 16:25:01 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
61 (only retried tests) 26 0 4 1 30

🟢 2025-03-25 16:25:11 UTC Build successful.
🟡 2025-03-25 16:25:42 UTC ydbd size 3.8 GiB changed* by +111.0 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 9808a23 merge: 9bdddb1 diff diff %
ydbd size 4 083 584 232 Bytes 4 083 697 944 Bytes +111.0 KiB +0.003%
ydbd stripped size 1 410 980 552 Bytes 1 411 136 520 Bytes +152.3 KiB +0.011%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@UgnineSirdis UgnineSirdis force-pushed the refactor-ydb-cli-options branch from 67ec18a to 0f5bcb0 Compare March 26, 2025 14:51
@github-actions

github-actions Bot commented Mar 26, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

⚪ 2025-03-26 14:55:54 UTC Pre-commit check linux-x86_64-release-asan for dd8ea80 has started.
⚪ 2025-03-26 14:56:09 UTC Artifacts will be uploaded here
⚪ 2025-03-26 14:59:08 UTC ya make is running...
🟡 2025-03-26 16:15:19 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12397 12305 0 44 15 33

⚪ 2025-03-26 16:16:26 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-26 16:31:50 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
125 (only retried tests) 85 0 4 7 29

⚪ 2025-03-26 16:31:58 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-03-26 16:43:44 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
63 (only retried tests) 25 0 4 7 27

🟢 2025-03-26 16:43:51 UTC Build successful.
🟡 2025-03-26 16:44:21 UTC ydbd size 3.8 GiB changed* by +121.6 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: cb28e2e merge: dd8ea80 diff diff %
ydbd size 4 110 766 640 Bytes 4 110 891 184 Bytes +121.6 KiB +0.003%
ydbd stripped size 1 420 472 744 Bytes 1 420 632 808 Bytes +156.3 KiB +0.011%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions

github-actions Bot commented Mar 26, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

⚪ 2025-03-26 14:55:56 UTC Pre-commit check linux-x86_64-relwithdebinfo for dd8ea80 has started.
⚪ 2025-03-26 14:56:12 UTC Artifacts will be uploaded here
⚪ 2025-03-26 14:59:06 UTC ya make is running...
🟡 2025-03-26 16:11:47 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
26898 24236 0 4 2548 110

⚪ 2025-03-26 16:14:11 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-03-26 16:25:42 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
164 (only retried tests) 61 0 0 0 103

🟢 2025-03-26 16:25:51 UTC Build successful.
🟢 2025-03-26 16:26:09 UTC ydbd size 2.2 GiB changed* by +41.1 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: cb28e2e merge: dd8ea80 diff diff %
ydbd size 2 342 840 728 Bytes 2 342 882 832 Bytes +41.1 KiB +0.002%
ydbd stripped size 489 905 088 Bytes 489 936 032 Bytes +30.2 KiB +0.006%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@UgnineSirdis UgnineSirdis enabled auto-merge (squash) March 26, 2025 14:57
@UgnineSirdis UgnineSirdis merged commit 352a038 into ydb-platform:main Mar 26, 2025
lberserq pushed a commit to lberserq/ydb that referenced this pull request Mar 28, 2025
@UgnineSirdis
Refactor ydb cli options (ydb-platform#15800)
dc01146
@UgnineSirdis UgnineSirdis deleted the refactor-ydb-cli-options branch May 14, 2025 06:57
@liruoko liruoko added the changelog/f25-3 PR участвует в списке изменений label Nov 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dcherednik dcherednik dcherednik approved these changes
@pnv1 pnv1 pnv1 approved these changes

Assignees

No one assigned

Labels

changelog/f25-3 PR участвует в списке изменений improvement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@UgnineSirdis @dcherednik @pnv1 @liruoko